[PATCH] D122065: [BOLT] Align constant islands to 8 bytes

Vladislav Khmelevsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 27 12:29:58 PDT 2022


yota9 marked an inline comment as done.
yota9 added a comment.

Thank you for your review @maksfb ! I agree with your concerns but currently I don't have a good idea too. Within the time I hope we will find a solution :)



================
Comment at: bolt/test/AArch64/constant-island-alignment.s:12
+
+# CHECK: {{0|8}} <$d>:
+
----------------
maksfb wrote:
> nit: place the CHECK next to the asm directive that corresponds to the island being checked. I don't know how the names are assigned for islands and if it's possible to give it a distinctive name.
Done. The $d is the arm ABI name, there is no way to manipulate this AFAIK 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122065/new/

https://reviews.llvm.org/D122065



More information about the llvm-commits mailing list