[PATCH] D122065: [BOLT] Align constant islands to 8 bytes

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb accepted this revision.
maksfb added a comment.
This revision is now accepted and ready to land.

Overall LGTM.

I have a general concern that the estimation of the size for islands and the actual emission are decoupled and could get out of sync. At the same time, I don't have a good suggestion on how to fix it. For functions, to calculate the size we create a temporary emitter and run the same code used for real emission, get the size of the emitted code and then discard the code.



================
Comment at: bolt/test/AArch64/constant-island-alignment.s:12
+
+# CHECK: {{0|8}} <$d>:
+
----------------
nit: place the CHECK next to the asm directive that corresponds to the island being checked. I don't know how the names are assigned for islands and if it's possible to give it a distinctive name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122065/new/

https://reviews.llvm.org/D122065