[PATCH] D122039: [BOLT] Fix plt relocations symbol match

Vladislav Khmelevsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 27 12:17:47 PDT 2022


yota9 marked an inline comment as done.
yota9 added inline comments.


================
Comment at: bolt/include/bolt/Core/BinaryContext.h:779
+  /// or nullptr if no global PLT symbol with that name exists.
+  const BinaryData *getPltBinaryDataByName(StringRef Name) const {
+    if (const BinaryData *Data = getBinaryDataByName(Name.str() + "@PLT"))
----------------
maksfb wrote:
> nit: could you use PLT (all caps) in function names to be consistent with the rest of the code in BOLT?
Yes, sure, I always forget about PLT.. :D


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122039/new/

https://reviews.llvm.org/D122039



More information about the llvm-commits mailing list