[PATCH] D122039: [BOLT] Fix plt relocations symbol match
Maksim Panchenko via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Mar 26 17:09:09 PDT 2022
maksfb added a comment.
Summary: s/linkeradds/linker adds/ and s/symbtab/symtab/
================
Comment at: bolt/include/bolt/Core/BinaryContext.h:779
+ /// or nullptr if no global PLT symbol with that name exists.
+ const BinaryData *getPltBinaryDataByName(StringRef Name) const {
+ if (const BinaryData *Data = getBinaryDataByName(Name.str() + "@PLT"))
----------------
nit: could you use PLT (all caps) in function names to be consistent with the rest of the code in BOLT?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122039/new/
https://reviews.llvm.org/D122039
More information about the llvm-commits
mailing list