[PATCH] D122434: [Support] Add OpauqeDataStore

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 25 23:26:06 PDT 2022


MaskRay added a comment.

This is like a heterogeneous list in FP. I also wonder whether we should use llvm::Any instead. We cannot use C++17 <https://discourse.llvm.org/t/rfc-increasing-the-gcc-and-clang-requirements-to-support-c-17-in-llvm/59983> std::any yet.
(Also, llvm::Any has the `LLVM_EXTERNAL_VISIBILITY` trick. I don't know how std::any behaves in various STL implementations in the presence of LLVM_LINK_LLVM_DYLIB)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122434/new/

https://reviews.llvm.org/D122434



More information about the llvm-commits mailing list