[PATCH] D122434: [Support] Add OpauqeDataStore

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/include/llvm/Support/OpaqueDataStore.h:70
+      return insert<DataT>();
+    return *(DataT *)It->get();
+  }
----------------
I'd probably go with a C++ style cast, to be clear what conversions are happening here.


================
Comment at: llvm/include/llvm/Support/OpaqueDataStore.h:115
+
+  SmallVector<std::unique_ptr<StoredDataBase>, 8> Storage;
+};
----------------
Is storage of multiple items necessary, or could this be more like std::any? (could we use std::any instead of adding this new thing?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122434/new/

https://reviews.llvm.org/D122434