[PATCH] D122477: [X86][tablgen] Consider the mnemonic when auto-generating memory folding table

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 25 22:31:43 PDT 2022


skan added a comment.

In D122477#3409372 <https://reviews.llvm.org/D122477#3409372>, @craig.topper wrote:

> Do you intend to replace the other cases that use NotMemoryFoldable in the .td file which was how we used to fix this issue. See the multiple cases already in X86InstrVMX.td

I can see you added them in https://reviews.llvm.org/rG66572df76eb9acf5c6b84c573541065cb29ce2ff
I think most of `NotMemoryFoldable` can be saved by checking the `SchedRW` is not `WriteNop` or `WriteSystem`. Do you mind I do it in another NFC patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122477/new/

https://reviews.llvm.org/D122477



More information about the llvm-commits mailing list