[PATCH] D122477: [X86][tablgen] Consider the mnemonic when auto-generating memory folding table

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 25 20:58:55 PDT 2022


craig.topper added a comment.

Do you intend to replace the other cases that use NotMemoryFoldable in the .td file which was how we used to fix this issue.



================
Comment at: llvm/utils/TableGen/X86FoldTablesEmitter.cpp:335
+    //
+    // This two instruction have similiar encoding fileds but are unrelated
+    if (X86Disassembler::getMnemonic(MemInst, Variant) !=
----------------
fileds -> fields


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122477/new/

https://reviews.llvm.org/D122477



More information about the llvm-commits mailing list