[PATCH] D122477: [X86][tablgen] Consider the mnemonic when auto-generating memory folding table

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 25 06:23:51 PDT 2022


skan added a comment.

As craig says, there is already a big test coverage hole on the hand-written memory folding tables. To make something easier, I have the following plan:

1. Gradually fix the gap between auto-generated folding table and the hand-written one
2. When the two are totally same, I will use the auto-generated table by default add a LIT test to check each entry of the table (sth like llvm/utils/update_llc_test_checks.py would be added)

Then we can prevent the possible regression in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122477/new/

https://reviews.llvm.org/D122477



More information about the llvm-commits mailing list