[PATCH] D122477: [X86][tablgen] Consider the mnemonic when auto-generating memory folding table

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 25 06:09:35 PDT 2022


skan created this revision.
skan added reviewers: craig.topper, Amir, pengfei.
Herald added subscribers: StephenFan, hiraditya, mgorny.
Herald added a project: All.
skan requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Intuitively, the memory folding pair should have the same mnemonic.

This patch removes

  {X86::SENDUIPI,X86::VMXON}

in the auto-generated table.

  {X86::MOVLHPSrr,X86::MOVHPSrm}
  {X86::VMOVLHPSZrr,X86::VMOVHPSZ128rm}
  {X86::VMOVLHPSrr,X86::VMOVHPSrm}

It seems the three pairs above are mistakenly killed.
But we can add them back manually later.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D122477

Files:
  llvm/lib/Target/X86/CMakeLists.txt
  llvm/utils/TableGen/X86FoldTablesEmitter.cpp
  llvm/utils/TableGen/X86MnemonicTables.cpp
  llvm/utils/TableGen/X86RecognizableInstr.cpp
  llvm/utils/TableGen/X86RecognizableInstr.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122477.418200.patch
Type: text/x-patch
Size: 5254 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220325/3d45094a/attachment.bin>


More information about the llvm-commits mailing list