[PATCH] D122427: [MIPS] Initial support for MIPS-I load delay slots

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

Hi @impiaaa, thanks for working on this!
Since this is an initial support, I was wondering is there a clear set of TODOs that need to be done?



================
Comment at: llvm/lib/Target/Mips/MipsBranchExpansion.cpp:893
   ForceLongBranchFirstPass = ForceLongBranch;
-  // Run these two at least once
+  // Run these at least once
   bool longBranchChanged = handlePossibleLongBranch();
----------------
nit: `.` at the end of the comment


================
Comment at: llvm/lib/Target/Mips/MipsBranchExpansion.cpp:899-900
 
-  bool Changed =
-      longBranchChanged || forbiddenSlotChanged || fpuDelaySlotChanged;
+  bool Changed = longBranchChanged || forbiddenSlotChanged ||
+                 fpuDelaySlotChanged || loadDelaySlotChanged;
 
----------------
is this clang-formatted?


================
Comment at: llvm/lib/Target/Mips/MipsInstrInfo.cpp:600
 }
 
+bool MipsInstrInfo::SafeInLoadDelaySlot(const MachineInstr &MIInSlot,
----------------
a comment describing the predicate?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122427/new/

https://reviews.llvm.org/D122427