[PATCH] D122428: Make BLAKE3 a component library

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 12:45:52 PDT 2022


MaskRay added inline comments.


================
Comment at: llvm/lib/Support/BLAKE3/CMakeLists.txt:49
+
+add_library(llvm_blake3 OBJECT EXCLUDE_FROM_ALL ${LLVM_BLAKE3_FILES})
+llvm_update_compile_flags(llvm_blake3)
----------------
Should this be named `LLVMSupportBlake3` to match the prevailing library naming convention and BUILD.gn?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122428/new/

https://reviews.llvm.org/D122428



More information about the llvm-commits mailing list