[PATCH] D122428: Make BLAKE3 a component library

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 12:42:24 PDT 2022


thakis created this revision.
thakis added a reviewer: akyrtzi.
Herald added subscribers: dexonsmith, hiraditya, mgorny.
Herald added a project: All.
thakis requested review of this revision.
Herald added a project: LLVM.

It's unusual that BLAKE3/CMakeLists.txt just defines a list of
files that it injects into its parent scope. The list should either
be defined in llvm/lib/Support/CMakeLists.txt, or
llvm/lib/Support/BLAKE3/CMakeLists.txt should define an object
library.

This does the latter. It makes llvm/lib/Support/BLAKE3/CMakeLists.txt
more self-contained.

No behavior change.


https://reviews.llvm.org/D122428

Files:
  llvm/lib/Support/BLAKE3/CMakeLists.txt
  llvm/lib/Support/CMakeLists.txt
  llvm/utils/gn/secondary/llvm/lib/Support/BLAKE3/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122428.418023.patch
Type: text/x-patch
Size: 4335 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220324/b4a5f7cb/attachment.bin>


More information about the llvm-commits mailing list