[PATCH] D122065: [BOLT] Align constant islands to 8 bytes

[Vladislav Khmelevsky via Phabricator via llvm-commits]

yota9 added a comment.

Hello @maksfb !

> This way you will be able to run tests on other architectures.

Sure, but the testing is currently does not run aarch64 tests at all. 
I don't really mind, but sometimes it is just inconvenient  to make such tests. And I still would like some tests to be runnable.. I think we need to discuss the testing policy.

> Regarding the change itself, have you considered aligning constant islands so that they straddle a minimum number of cache lines?

This could be discussed, but we need to check if there will be any winning in this, I don't think this is a good way just to align to cache line size, it should be more clever system, but this is beyond the goals of this review. But thank you for you suggestion anyway :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122065/new/

https://reviews.llvm.org/D122065