[PATCH] D122065: [BOLT] Align constant islands to 8 bytes

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb requested changes to this revision.
maksfb added a comment.
This revision now requires changes to proceed.

@yota9, similar to my concerns on other diffs, I think it's better for regression tests to check for a specific condition and not to rely on the correct execution of the test binary. This way you will be able to run tests on other architectures.

Regarding the change itself, have you considered aligning constant islands so that they straddle a minimum number of cache lines? The trivial way to achieve this is to align them at cache line boundary, but it's not always the optimal way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122065/new/

https://reviews.llvm.org/D122065