[PATCH] D121973: Recommit "[SLP] Fix lookahead operand reordering for splat loads."

[Vasileios Porpodas via Phabricator via llvm-commits]

vporpo added a comment.

Recommitted fixed patch: 39aa202affd99d1713daea00b7681571fe478a12 <https://reviews.llvm.org/rG39aa202affd99d1713daea00b7681571fe478a12>



================
Comment at: llvm/lib/Target/X86/X86TargetTransformInfo.cpp:1562
+                   BaseTp->getElementType(),
+                   cast<FixedVectorType>(BaseTp)->getNumElements()) &&
+               "Table entry missing from isLegalBroadcastLoad()");
----------------
RKSimon wrote:
> This isn't accounting for type legalization reducing the width of the broadcasted vector  - you probably need to use LT.second.getVectorNumElements().
Yeah this was the issue, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121973/new/

https://reviews.llvm.org/D121973