[PATCH] D121973: Recommit "[SLP] Fix lookahead operand reordering for splat loads."

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 23 11:43:22 PDT 2022


RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86TargetTransformInfo.cpp:1562
+                   BaseTp->getElementType(),
+                   cast<FixedVectorType>(BaseTp)->getNumElements()) &&
+               "Table entry missing from isLegalBroadcastLoad()");
----------------
This isn't accounting for type legalization reducing the width of the broadcasted vector  - you probably need to use LT.second.getVectorNumElements().


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121973/new/

https://reviews.llvm.org/D121973



More information about the llvm-commits mailing list