[PATCH] D122226: [llmv-pdbutil] Move InputFile/FormatUtil/LinePrinter to the PDB library.

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added a comment.

There's a typo in the title:

> [ll**mv**-pdbutil] Move InputFile/FormatUtil/LinePrinter to PDB library.

llvm-pdbutil



================
Comment at: llvm/lib/DebugInfo/PDB/Native/LinePrinter.cpp:33
 
+FilterOptions llvm::pdb::Filters;
+
----------------
Not a blocker, but I'm a bit allergic to global state, especially in a lib. I wonder how much work it would be to keep this `Filters` state inside the `LinePrinter` class and pass it by reference to the `iterate*` functions. That could be done in a later patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122226/new/

https://reviews.llvm.org/D122226