[PATCH] D122226: [llmv-pdbutil] Move InputFile/FormatUtil/LinePrinter to the PDB library.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 23 15:53:09 PDT 2022


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/include/llvm/DebugInfo/PDB/Native/InputFile.h:163
+
+template <typename CallbackT>
+Error iterateOneModule(InputFile &File, const Optional<PrintScope> &HeaderScope,
----------------
These callbacks look like they could actually be function_refs. Can you put a // TODO comment here to de-templatify them? I don't want to block on it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122226/new/

https://reviews.llvm.org/D122226



More information about the llvm-commits mailing list