[llvm] 681fd2c - Revert "[SelectionDAG] Don't create entries in ValueMap in ComputePHILiveOutRegInfo"

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 22 23:41:55 PDT 2022


Author: Craig Topper
Date: 2022-03-22T23:41:47-07:00
New Revision: 681fd2c11e0819b32ca514b2b989f1a246c0b33b

URL: https://github.com/llvm/llvm-project/commit/681fd2c11e0819b32ca514b2b989f1a246c0b33b
DIFF: https://github.com/llvm/llvm-project/commit/681fd2c11e0819b32ca514b2b989f1a246c0b33b.diff

LOG: Revert "[SelectionDAG] Don't create entries in ValueMap in ComputePHILiveOutRegInfo"

This reverts commit 1a9b55b63a6e18a4692eeb795697cb61ca1b002f.

Causing build bot failures

Added: 
    

Modified: 
    llvm/include/llvm/CodeGen/FunctionLoweringInfo.h
    llvm/lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/CodeGen/FunctionLoweringInfo.h b/llvm/include/llvm/CodeGen/FunctionLoweringInfo.h
index 071242e145327..524730d536942 100644
--- a/llvm/include/llvm/CodeGen/FunctionLoweringInfo.h
+++ b/llvm/include/llvm/CodeGen/FunctionLoweringInfo.h
@@ -258,7 +258,6 @@ class FunctionLoweringInfo {
       return;
 
     Register Reg = It->second;
-    assert(Reg != 0);
     if (Reg == 0)
       return;
 

diff  --git a/llvm/lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp b/llvm/lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp
index e39ad73cf20c9..b49455111a468 100644
--- a/llvm/lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp
@@ -445,14 +445,9 @@ void FunctionLoweringInfo::ComputePHILiveOutRegInfo(const PHINode *PN) {
   IntVT = TLI->getTypeToTransformTo(PN->getContext(), IntVT);
   unsigned BitWidth = IntVT.getSizeInBits();
 
-  auto It = ValueMap.find(PN);
-  if (It == ValueMap.end())
+  Register DestReg = ValueMap[PN];
+  if (!Register::isVirtualRegister(DestReg))
     return;
-
-  Register DestReg = It->second;
-  if (DestReg == 0)
-    return
-  assert(Register::isVirtualRegister(DestReg) && "Expected a virtual reg");
   LiveOutRegInfo.grow(DestReg);
   LiveOutInfo &DestLOI = LiveOutRegInfo[DestReg];
 


        


More information about the llvm-commits mailing list