[PATCH] D110267: [InlineAsm, SystemZ] Handle inline assembly address operands.

[Jonas Paulsson via Phabricator via llvm-commits]

jonpa updated this revision to Diff 417238.
jonpa removed reviewers: rnk, Amanieu, cynecx, lewis-revill, dsanders.
jonpa added a comment.
Herald added a project: All.

Patch updated per review...

> Using different C_Address and C_Memory types would also force all places that treat constaints to be explicitly updated to handle address constraints, requiring deliberate choices. This seems preferable since the constraint types frequently do require different treatment.

Ok - I tried this at https://reviews.llvm.org/D122220.

> So it might make sense to have two patches instead, a first patch that introduces the C_Address mechanism, and uses it to implement the "p" constraint in a platform-independent manner, fixing in particular this bug on Intel. And then in a second patch add the SystemZ-specific address constraints.

This patch here is now the SystemZ specific address constraints, on top of the patch for "p" (see above).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110267/new/

https://reviews.llvm.org/D110267

Files:
  clang/lib/Basic/Targets/SystemZ.cpp
  clang/lib/Basic/Targets/SystemZ.h
  clang/test/CodeGen/SystemZ/systemz-inline-asm-03.c
  llvm/include/llvm/IR/InlineAsm.h
  llvm/lib/Target/SystemZ/SystemZISelDAGToDAG.cpp
  llvm/lib/Target/SystemZ/SystemZISelLowering.cpp
  llvm/lib/Target/SystemZ/SystemZISelLowering.h
  llvm/test/CodeGen/SystemZ/inline-asm-addr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110267.417238.patch
Type: text/x-patch
Size: 16164 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220322/c4abf8d6/attachment.bin>