[PATCH] D122167: Compiler: Remove empty fallback definition for LLVM_BUILTIN_UNREACHABLE

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a comment.

Thanks for the review! Landed in 892c104fb71b86dc6399e36a82ae920e00ccae17 <https://reviews.llvm.org/rG892c104fb71b86dc6399e36a82ae920e00ccae17>.

In D122167#3397263 <https://reviews.llvm.org/D122167#3397263>, @dexonsmith wrote:

> Alternatively, maybe we don't support building with compilers that don't have a builtin unreachable anymore, and can have:
>
>   #else
>   #error
>
> and we can simplify logic that depends on this macro... but it seems bit friendlier to keep this alive since it doesn't seem hard.

(Can always do that as a follow-up if it makes sense.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122167/new/

https://reviews.llvm.org/D122167