[PATCH] D111581: Remove checks for old gcc versions for LLVM_ATTRIBUTE_*

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added inline comments.
Herald added a subscriber: StephenFan.
Herald added a project: All.


================
Comment at: llvm/include/llvm/Support/Compiler.h:333-334
 # define LLVM_BUILTIN_UNREACHABLE __assume(false)
+#else
+# define LLVM_BUILTIN_UNREACHABLE
 #endif
----------------
I don't think this was the correct thing to do since it subverts the checks for `defined(LLVM_BUILTIN_UNREACHABLE)`. See review for a partial revert in:
https://reviews.llvm.org/D122167



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111581/new/

https://reviews.llvm.org/D111581