[PATCH] D122134: [WebAssembly] Always emit functype directives for defined functions

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 21 07:00:57 PDT 2022


asb created this revision.
asb added reviewers: pmatos, tlively, aheejin, aardappel.
Herald added subscribers: ecnelises, sameer.abuasal, sunfish, hiraditya, jgravelle-google, sbc100, dschuff.
Herald added a project: All.
asb requested review of this revision.
Herald added a project: LLVM.

This address bug https://github.com/llvm/llvm-project/issues/54022. For now this means that defined functions will have two .functype directives emitted. Given discussion in that bug has suggested interest
in moving towards using something other than .functype to mark the beginning of a function (which would, as a side-effect, solve this issue), this patch doesn't attempt to avoid that duplication.


https://reviews.llvm.org/D122134

Files:
  llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.h
  llvm/test/CodeGen/WebAssembly/byval.ll
  llvm/test/CodeGen/WebAssembly/cfg-stackify-eh.ll
  llvm/test/CodeGen/WebAssembly/function-pointer64.ll
  llvm/test/CodeGen/WebAssembly/functype-emission.ll
  llvm/test/CodeGen/WebAssembly/inlineasm-output-template.ll
  llvm/test/CodeGen/WebAssembly/multi-return.ll
  llvm/test/CodeGen/WebAssembly/stack-protector.ll
  llvm/test/MC/WebAssembly/stack-ptr-mclower.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122134.416918.patch
Type: text/x-patch
Size: 11636 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220321/407bcc85/attachment.bin>


More information about the llvm-commits mailing list