[PATCH] D121995: [AMDGPU][MC][NFC] Refactored sendmsg(...) handling

[Dmitry Preobrazhensky via Phabricator via llvm-commits]

dp marked 2 inline comments as done.
dp added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp:1500
 
+bool isGFX6_GFX7_GFX8_GFX9(const MCSubtargetInfo &STI) {
+  return isSI(STI) || isCI(STI) || isVI(STI) || isGFX9(STI);
----------------
foad wrote:
> Maybe it would be simpler to implement this as "isNotGFX10Plus" instead?
Thanks, corrected.


================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp:1522
 
+bool isGFX10RDNA1(const MCSubtargetInfo &STI) {
+  return isGFX10(STI) && !AMDGPU::isGFX10_BEncoding(STI);
----------------
foad wrote:
> In AMDGPU.td there is a predicate called "isGFX10Before1030". Maybe we should use the same name in both places? I don't have a preference for which name is better.
I'd have preferred isGFX10RDNA1 but I do not want to correct code that is not related to this change. So I'll use isGFX10Before1030 as you suggested.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121995/new/

https://reviews.llvm.org/D121995