[PATCH] D121995: [AMDGPU][MC][NFC] Refactored sendmsg(...) handling

Mon Mar 21 03:43:50 PDT 2022

foad added a comment.

LGTM (with or without addressing my nitpicks about naming).

================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp:1500

+bool isGFX6_GFX7_GFX8_GFX9(const MCSubtargetInfo &STI) {
+  return isSI(STI) || isCI(STI) || isVI(STI) || isGFX9(STI);
----------------
Maybe it would be simpler to implement this as "isNotGFX10Plus" instead?

================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp:1522

+bool isGFX10RDNA1(const MCSubtargetInfo &STI) {
+  return isGFX10(STI) && !AMDGPU::isGFX10_BEncoding(STI);
----------------
In AMDGPU.td there is a predicate called "isGFX10Before1030". Maybe we should use the same name in both places? I don't have a preference for which name is better.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121995/new/

https://reviews.llvm.org/D121995