[PATCH] D121721: Move DWARFRecordSectionSplitter code to its own file

[Shubham Sandeep Rastogi via Phabricator via llvm-commits]

rastogishubham marked an inline comment as done.
rastogishubham added inline comments.


================
Comment at: llvm/include/llvm/ExecutionEngine/JITLink/DWARFRecordSectionSplitter.h:12
+
+#include "llvm/ExecutionEngine/JITLink/JITLink.h"
+#include "llvm/Support/BinaryStreamReader.h"
----------------
aprantl wrote:
> I don't think this is needed. All the types could be forward-declared (they are just used as references here).
This include is also here because of the cpp file which requires this include, should I move this to the cpp file?


================
Comment at: llvm/include/llvm/ExecutionEngine/JITLink/DWARFRecordSectionSplitter.h:13
+#include "llvm/ExecutionEngine/JITLink/JITLink.h"
+#include "llvm/Support/BinaryStreamReader.h"
+
----------------
aprantl wrote:
> what is this needed for?
This is needed because in the cpp file it creates a BinaryStreamReader, should I move the include to the cpp file instead?

llvm/lib/ExecutionEngine/JITLink/DWARFRecordSectionSplitter.cpp:76

```
BinaryStreamReader BlockReader(
      StringRef(B.getContent().data(), B.getContent().size()),
      G.getEndianness());
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121721/new/

https://reviews.llvm.org/D121721