[PATCH] D121721: Move DWARFRecordSectionSplitter code to its own file

[Shubham Sandeep Rastogi via Phabricator via llvm-commits]

rastogishubham added inline comments.


================
Comment at: llvm/include/llvm/ExecutionEngine/JITLink/DWARFRecordSectionSplitter.h:12
+
+#include "llvm/ExecutionEngine/JITLink/JITLink.h"
+#include "llvm/Support/BinaryStreamReader.h"
----------------
rastogishubham wrote:
> aprantl wrote:
> > I don't think this is needed. All the types could be forward-declared (they are just used as references here).
> This include is also here because of the cpp file which requires this include, should I move this to the cpp file?
Hmm, I was wrong, but the forward declaration will not work here because it also uses a nested class which I do not think can be forward declared


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121721/new/

https://reviews.llvm.org/D121721