[PATCH] D121721: Move DWARFRecordSectionSplitter code to its own file

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

This is generally fine, I have a few nitpicks inline :-)



================
Comment at: llvm/include/llvm/ExecutionEngine/JITLink/DWARFRecordSectionSplitter.h:1
+//===--------- DWARFRecordSectionSplittert.h - JITLink ----------*- C++ -*-===//
+//
----------------
typo: Splittert


================
Comment at: llvm/include/llvm/ExecutionEngine/JITLink/DWARFRecordSectionSplitter.h:12
+
+#include "llvm/ExecutionEngine/JITLink/JITLink.h"
+#include "llvm/Support/BinaryStreamReader.h"
----------------
I don't think this is needed. All the types could be forward-declared (they are just used as references here).


================
Comment at: llvm/include/llvm/ExecutionEngine/JITLink/DWARFRecordSectionSplitter.h:13
+#include "llvm/ExecutionEngine/JITLink/JITLink.h"
+#include "llvm/Support/BinaryStreamReader.h"
+
----------------
what is this needed for?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121721/new/

https://reviews.llvm.org/D121721