[PATCH] D121638: [lld-macho] Avoid using bump-alloc in TrieBuider

[Sterling Augustine via Phabricator via llvm-commits]

saugustine added a comment.

Or, if you prefer the cmake version:

  [159/255] Building CXX object tools/lld/MachO/CMakeFiles/lldMachO.dir/ExportTrie.cpp.o
  FAILED: tools/lld/MachO/CMakeFiles/lldMachO.dir/ExportTrie.cpp.o 
  /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/usr/local/google/home/saugustine/llvm/build/tools/lld/MachO -I/usr/local/google/home/saugustine/llvm/llvm-project/lld/MachO -I/usr/local/google/home/saugustine/llvm/llvm-project/lld/include -I/usr/local/google/home/saugustine/llvm/build/tools/lld/include -I/usr/local/google/home/saugustine/llvm/build/include -I/usr/local/google/home/saugustine/llvm/llvm-project/llvm/include -I/usr/local/google/home/saugustine/llvm/llvm-project/llvm/../libunwind/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -fdiagnostics-color -g  -fno-exceptions -fno-rtti -std=c++17 -MD -MT tools/lld/MachO/CMakeFiles/lldMachO.dir/ExportTrie.cpp.o -MF tools/lld/MachO/CMakeFiles/lldMachO.dir/ExportTrie.cpp.o.d -o tools/lld/MachO/CMakeFiles/lldMachO.dir/ExportTrie.cpp.o -c /usr/local/google/home/saugustine/llvm/llvm-project/lld/MachO/ExportTrie.cpp
  /usr/local/google/home/saugustine/llvm/llvm-project/lld/MachO/ExportTrie.cpp:148:11: error: definition of implicitly declared destructor
  TrieNode::~TrieNode() {
            ^
  /usr/local/google/home/saugustine/llvm/llvm-project/lld/MachO/ExportTrie.cpp:149:25: error: use of undeclared identifier 'nodes'; did you mean 'node'?
    for (TrieNode *node : nodes)
                          ^~~~~
                          node
  /usr/local/google/home/saugustine/llvm/llvm-project/lld/MachO/ExportTrie.cpp:149:18: note: 'node' declared here
    for (TrieNode *node : nodes)
                   ^
  /usr/local/google/home/saugustine/llvm/llvm-project/lld/MachO/ExportTrie.cpp:149:23: error: invalid range expression of type 'lld::macho::TrieNode *'; no viable 'begin' function available
    for (TrieNode *node : nodes)
                        ^ ~~~~~
  3 errors generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121638/new/

https://reviews.llvm.org/D121638