[PATCH] D121638: [lld-macho] Avoid using bump-alloc in TrieBuider

Mon Mar 14 15:15:24 PDT 2022

saugustine added a comment.

This change breaks the lld build with:

  ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ac6467df252ff017b0d6ba076db369db/external/llvm-project/lld/BUILD.bazel:191:11: Compiling lld/MachO/ExportTrie.cpp failed: (Exit 1): clang failed: error executing command /usr/local/bin/clang -U_FORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety -Wself-assign -fcolor-diagnostics -fno-omit-frame-pointer '-std=c++0x' -MD -MF ... (remaining 81 argument(s) skipped)
  external/llvm-project/lld/MachO/ExportTrie.cpp:148:11: error: definition of implicitly declared destructor
  TrieNode::~TrieNode() {
            ^
  external/llvm-project/lld/MachO/ExportTrie.cpp:149:25: error: use of undeclared identifier 'nodes'; did you mean 'node'?
    for (TrieNode *node : nodes)
                          ^~~~~
                          node
  external/llvm-project/lld/MachO/ExportTrie.cpp:149:18: note: 'node' declared here
    for (TrieNode *node : nodes)
                   ^
  external/llvm-project/lld/MachO/ExportTrie.cpp:149:23: error: invalid range expression of type 'lld::macho::TrieNode *'; no viable 'begin' function available
    for (TrieNode *node : nodes)
                        ^ ~~~~~
  3 errors generated.

Reverting shortly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121638/new/

https://reviews.llvm.org/D121638