[PATCH] D121638: [lld-macho] Avoid using bump-alloc in TrieBuider

Mon Mar 14 15:19:20 PDT 2022

codemzs added a comment.

This change has broke windows builds:

FAILED: tools/lld/MachO/CMakeFiles/lldMachO.dir/ExportTrie.cpp.obj
C:\PROGRA2\MICROS1\2019\ENTERP1\VC\Tools\MSVC\14291.301\bin\Hostx64\x64\cl.exe /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -ID:\a_work\1\b\llvm\Debug\tools\lld\MachO -ID:\a_work\1\llvm-project\lld\MachO -ID:\a_work\1\llvm-project\lld\include -ID:\a_work\1\b\llvm\Debug\tools\lld\include -ID:\a_work\1\b\llvm\Debug\include -ID:\a_work\1\llvm-project\llvm\include -ID:\a_work\1\llvm-project\llvm..\libunwind\include /DWIN32 /D_WINDOWS /Zc:inline /Zc:__cplusplus /Zc:strictStrings /Oi /Zc:rvalueCast /bigobj /W4 <https://reviews.llvm.org/W4> -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd4324 -w14062 -we4238 /MDd /Zi /Ob0 /Od /RTC1 -wd4530 -wd4062 /EHs-c- /GR- -std:c++14 /showIncludes /Fotools\lld\MachO\CMakeFiles\lldMachO.dir\ExportTrie.cpp.obj /Fdtools\lld\MachO\CMakeFiles\lldMachO.dir\lldMachO.pdb /FS -c D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(148): error C2600: 'lld::macho::TrieNode::~TrieNode': cannot define a compiler-generated special member function (must be declared in the class first)
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(149): error C2065: 'nodes': undeclared identifier
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(148): note: This diagnostic occurred in the compiler generated function 'lld::macho::TrieNode::~TrieNode(void)'
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(149): error C2672: 'begin': no matching overloaded function found
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(148): note: This diagnostic occurred in the compiler generated function 'lld::macho::TrieNode::~TrieNode(void)'
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(150): error C2893: Failed to specialize function template 'unknown-type std::begin(_Container &)'
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\xutility(1916): note: see declaration of 'std::begin'
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(150): note: With the following template arguments:
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(150): note: '_Container=unknown-type'
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(148): note: This diagnostic occurred in the compiler generated function 'lld::macho::TrieNode::~TrieNode(void)'
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(150): error C2784: 'const _Elem *std::begin(std::initializer_list<_Elem>) noexcept': could not deduce template argument for 'std::initializer_list<_Elem>' from 'unknown-type'
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\initializer_list(57): note: see declaration of 'std::begin'
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(148): note: This diagnostic occurred in the compiler generated function 'lld::macho::TrieNode::~TrieNode(void)'
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(149): error C2672: 'end': no matching overloaded function found
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(148): note: This diagnostic occurred in the compiler generated function 'lld::macho::TrieNode::~TrieNode(void)'
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(150): error C2893: Failed to specialize function template 'unknown-type std::end(_Container &)'
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\xutility(1926): note: see declaration of 'std::end'
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(150): note: With the following template arguments:
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(150): note: '_Container=unknown-type'
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(148): note: This diagnostic occurred in the compiler generated function 'lld::macho::TrieNode::~TrieNode(void)'
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(150): error C2784: 'const _Elem *std::end(std::initializer_list<_Elem>) noexcept': could not deduce template argument for 'std::initializer_list<_Elem>' from 'unknown-type'
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\initializer_list(63): note: see declaration of 'std::end'
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(148): note: This diagnostic occurred in the compiler generated function 'lld::macho::TrieNode::~TrieNode(void)'
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(150): error C3536: '$L0': cannot be used before it is initialized
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(148): note: This diagnostic occurred in the compiler generated function 'lld::macho::TrieNode::~TrieNode(void)'
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(150): error C3536: '$L0': cannot be used before it is initialized
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(148): note: This diagnostic occurred in the compiler generated function 'lld::macho::TrieNode::~TrieNode(void)'
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(149): error C2100: illegal indirection
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(148): note: This diagnostic occurred in the compiler generated function 'lld::macho::TrieNode::~TrieNode(void)'
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(149): error C2440: 'initializing': cannot convert from 'int' to 'lld::macho::TrieNode *'
D:\a_work\1\llvm-project\lld\MachO\ExportTrie.cpp(149): note: Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121638/new/

https://reviews.llvm.org/D121638