[PATCH] D120584: [NewPM][Inliner] Mark inlined calls to functions in same SCC as callee as noinline

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D120584#3364487 <https://reviews.llvm.org/D120584#3364487>, @aeubanks wrote:

> actually given that multiple people have complained about this issue, perhaps it's better with the `cl::opt` to just submit this, pass `-mllvm` where performance may be impacted, and have impacted people investigate this and come up with a potentially better solution

Right. I'd like to emphasize again that if impacted cases get reported, this allows us to address them in a data-driven way. For example, we now have two very similar solutions here and in D121084 <https://reviews.llvm.org/D121084>, but we don't have any way to evaluate whether the latter is better in any practical sense. If we had an impacted case, we could check whether or not it would be affected by D121084 <https://reviews.llvm.org/D121084>, with which cost multiplier, etc. Without having an affected case, we can only guess.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120584/new/

https://reviews.llvm.org/D120584