[PATCH] D120584: [NewPM][Inliner] Mark inlined calls to functions in same SCC as callee as noinline

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:97
+static cl::opt<bool> DisableNoinlineOnIntraSCCCalls(
+    "disable-noinline-on-intra-scc-calls", cl::init(false),
+    cl::desc("Disable marking inlined call sites that have a callee in the "
----------------
As I stated, I prefer this off by default, or the alternate patch:https://reviews.llvm.org/D121084


================
Comment at: llvm/test/Transforms/Inline/mut-rec-scc.ll:40
+  call void @test1()
+  call void @dummy()
+  call void @dummy()
----------------
aeubanks wrote:
> davidxl wrote:
> > can you add a callsite to a function test3() which is outside the SCC, where the test3's inlining is deferred until test2 is inlined.  This is to test that test3's inlining won't be suppressed.
> do you mean add a call inside test3 to some other new function (e.g. test4)?
ok to leave this as it is for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120584/new/

https://reviews.llvm.org/D120584