[PATCH] D120584: [NewPM][Inliner] Mark inlined calls to functions in same SCC as callee as noinline

Mon Mar 7 10:55:10 PST 2022

tstellar added a comment.

In D120584#3364322 <https://reviews.llvm.org/D120584#3364322>, @davidxl wrote:

> If this is doable, it feels like a winning strategy to me.

Yes, we could commit this patch directly to the release branch, and it seems like we may have to do this to get it in in time for the release, but I don't want that to slow down the effort to fix this in main.  I think we still need to come to some consensus on how to fix this in a timely manner in the main branch.

================
Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:97
+static cl::opt<bool> DisableNoinlineOnIntraSCCCalls(
+    "disable-noinline-on-intra-scc-calls", cl::init(false),
+    cl::desc("Disable marking inlined call sites that have a callee in the "
----------------
davidxl wrote:
> As I stated, I prefer this off by default, or the alternate patch:https://reviews.llvm.org/D121084
I'm a little confused by all negatives in the option, but I think the default state should be whatever state will fix PR45253.  This at least will get us closer to the old-pass-manager behavior and will unblock users.  I don't think the option is particularly useful if the default state doesn't fix PR45253.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120584/new/

https://reviews.llvm.org/D120584