[PATCH] D120584: [NewPM][Inliner] Mark inlined calls to functions in same SCC as callee as noinline

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 7 09:48:15 PST 2022


aeubanks added a comment.

actually given that multiple people have complained about this issue, perhaps it's better with the `cl::opt` to just submit this, pass `-mllvm` where performance may be impacted, and have impacted people investigate this and come up with a potentially better solution



================
Comment at: llvm/test/Transforms/Inline/mut-rec-scc.ll:40
+  call void @test1()
+  call void @dummy()
+  call void @dummy()
----------------
davidxl wrote:
> can you add a callsite to a function test3() which is outside the SCC, where the test3's inlining is deferred until test2 is inlined.  This is to test that test3's inlining won't be suppressed.
do you mean add a call inside test3 to some other new function (e.g. test4)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120584/new/

https://reviews.llvm.org/D120584



More information about the llvm-commits mailing list