[PATCH] D120229: [WebAssembly] Update WebAssemblyAsmTypeCheck for table.get
かめのこにょこにょこ via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 3 06:14:16 PST 2022
nokotan marked 3 inline comments as done.
nokotan added inline comments.
================
Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmTypeCheck.cpp:185
+bool WebAssemblyAsmTypeCheck::getTable(SMLoc ErrorLoc, const MCInst &Inst,
+ wasm::ValType &Type) {
----------------
aardappel wrote:
> This function is almost identically copy-pasted from `getGlobal`, please look into a way of merging these two functions cleanly.
Yes, originally this function was cloned from `getGlobal`.
For now, I guess that `getTable` does not have to get merged with `getGlobal`, since `getTable` is already modified.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120229/new/
https://reviews.llvm.org/D120229
More information about the llvm-commits
mailing list