[PATCH] D120229: [WebAssembly] Update WebAssemblyAsmTypeCheck for table.get
    Paulo Matos via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Mar  3 06:03:54 PST 2022
    
    
  
pmatos added a comment.
Thanks for your time working on the patch. It would be great to address @aardappel 's comments. The idea is to merge the function `getGlobal` with `getTable`, since they are so similar. I suppose into something like `getGlobalOrTable`. Add another switch case for `wasm::WASM_SYMBOL_TYPE_TABLE` to return the appropriate type.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120229/new/
https://reviews.llvm.org/D120229
    
    
More information about the llvm-commits
mailing list