[PATCH] D120229: [WebAssembly] Update WebAssemblyAsmTypeCheck for table.get

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 3 07:30:32 PST 2022


sbc100 added a comment.

In D120229#3349369 <https://reviews.llvm.org/D120229#3349369>, @aardappel wrote:

> I see my comment has not been addressed yet.

I don't see see any nice way to merge these two functions.  Since you made the original comment `getTable` has been simplified to make it more distinct.   Perhaps there is some way to templatize, but I don't see it.   I'd be OK with landing this change as is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120229/new/

https://reviews.llvm.org/D120229



More information about the llvm-commits mailing list