[PATCH] D120168: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [1/2]

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.
Herald added a project: All.

I don't think there are "rules" about tagging patches as NFC (just put NFC somewhere in the title). It's definitely helpful to be able to see at a glance though - two examples: if an NFC patch is causing changes in output there's a bug, and if a patch is NFC it probably doesn't need any tests.

Nearly ready to approve but I'm still stuck on one thing (sorry if I'm just missing something obvious!).



================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:6147
+
+  // If the pre-LSR expression was empty and the new expression is not, then
+  // DW_OP_stack_value must be appended. A non-empty pre-LSR expression must
----------------
My previous inline comment seems to have sunk further down, so I'm making a new one here. Sorry for holding things up but I still don't really understand what these few lines are for - I tried looking in the pre-patched code but couldn't find any similar code. What is the intended condition here and why does a `DW_OP_stack_value` need to be added under that condition?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120168/new/

https://reviews.llvm.org/D120168