[PATCH] D120168: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [1/2]

[Chris Jackson via Phabricator via llvm-commits]

chrisjackson updated this revision to Diff 412150.
chrisjackson added a comment.

Responded to review from @Orlando.

- Improved the comments with respect to writing shorter dbg.value. Its quite hard to explain concisely that DIArgList and {DW_OP_LLVM_arg, 0} aren't always necessary, but I tried.



- Renamed functions that had been moved inside SCEVDbgValueBuilder and were incorrectly cased.



- Yes, this patch is NFC, but I wasn't sure of the benefits / rules for labeling it as such. But I'm happy to do so.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120168/new/

https://reviews.llvm.org/D120168

Files:
  llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120168.412150.patch
Type: text/x-patch
Size: 13331 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220301/572b423b/attachment.bin>