[PATCH] D120168: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [1/2]

Wed Mar 2 05:02:02 PST 2022

chrisjackson added a comment.

In D120168#3354027 <https://reviews.llvm.org/D120168#3354027>, @Orlando wrote:

> I don't think there are "rules" about tagging patches as NFC (just put NFC somewhere in the title). It's definitely helpful to be able to see at a glance though - two examples: if an NFC patch is causing changes in output there's a bug, and if a patch is NFC it probably doesn't need any tests.
>
> Nearly ready to approve but I'm still stuck on one thing (sorry if I'm just missing something obvious!).

I can clarify the comment. It's my understanding that non-empty DIExpressions must have a DW_OP_stack_value terminator. The expressions generated by the SCEVDbgValueBuilder objects do not have these terminators (as the expressions may be inserted into other expressions). If the pre-LSR expression was empty, once the complete salvaging expression has been generated, then the terminator must be appended.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120168/new/

https://reviews.llvm.org/D120168