[PATCH] D120152: [AArch64][SVE] Match VLS all-1's masks to PTRUE

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 22 12:04:10 PST 2022


cameron.mcinally added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:14458
+  }
+
   // Only do this for legal fixed vector types.
----------------
I'm not sure if `getVScaleForTuning` is the right way to go here, but it seemed like the cleanest solution.

I also wonder if all `insert_subvector(undef, splat(X), 0)->splat(X)` should be canonicalized here. I don't have a strong opinion on it though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120152/new/

https://reviews.llvm.org/D120152



More information about the llvm-commits mailing list