[PATCH] D119039: [RISCV] Lower the shufflevector equivalent of vector.splice

Zakk Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 9 23:29:54 PST 2022


khchen accepted this revision.
khchen added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:2577
+  if (!Lo || !Hi)
+    return -1;
+
----------------
I'm wondering is there any cases which have only one value for valves?
I don't get it because X86 did the assignment if one of values not found but we return -1 here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119039/new/

https://reviews.llvm.org/D119039



More information about the llvm-commits mailing list