[PATCH] D119047: [OpaquePtr][LoopAccessAnalysis] Support opaque pointers

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:822
+      for (auto Access : Retries) {
+        for (auto &AccessTy : Accesses[Access]) {
+          if (!createCheckForAccess(RtCheck, Access, AccessTy, StridesMap,
----------------
fhahn wrote:
> fhahn wrote:
> > I think we need at least test cases where there are actually more than on AccessTy. This seems not be be covered by the existing tests at the moment
> Did you check if there's a test case with multiple access types that covers this code? It seems like this is still missing. One way to test this would be to have a loop-versioning test. IIUC multiple checks need to be generated with the correct access types now.
Oh sorry I got this part confused with the part above. I'm not super familiar with this so any help with constructing a test case would be appreciated, but I'll try to come up with one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119047/new/

https://reviews.llvm.org/D119047