[PATCH] D119047: [OpaquePtr][LoopAccessAnalysis] Support opaque pointers

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:822
+      for (auto Access : Retries) {
+        for (auto &AccessTy : Accesses[Access]) {
+          if (!createCheckForAccess(RtCheck, Access, AccessTy, StridesMap,
----------------
fhahn wrote:
> I think we need at least test cases where there are actually more than on AccessTy. This seems not be be covered by the existing tests at the moment
Did you check if there's a test case with multiple access types that covers this code? It seems like this is still missing. One way to test this would be to have a loop-versioning test. IIUC multiple checks need to be generated with the correct access types now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119047/new/

https://reviews.llvm.org/D119047