[PATCH] D119235: [AMDGPU][NFC] Fix typos

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 8 05:49:57 PST 2022


foad added a subscriber: critson.
foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIMachineScheduler.cpp:94
+// The OpenCL doc says for example latency of 400 cycles for a global mem
+// access, which is hidden by 10 instructions if the wavefront count is 10.
 
----------------
sebastian-ne wrote:
> foad wrote:
> > There is no typo fix here?
> True, I guess clang-format just formatted the whole comment, not only the changed line. (The lines were longer than 80 chars)
> Is it fine to leave these changes in the patch?
Yes, OK.


================
Comment at: llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp:980
   } else {
     // Kills deactivate lanes
     if (Op.isImm()) {
----------------
On second thoughts maybe "deactivated" was intended? And it needs to be fixed here too. @critson I think you wrote these comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119235/new/

https://reviews.llvm.org/D119235



More information about the llvm-commits mailing list