[PATCH] D119235: [AMDGPU][NFC] Fix typos

Tue Feb 8 05:30:08 PST 2022

sebastian-ne added inline comments.

================
Comment at: llvm/lib/Target/AMDGPU/R600InstrInfo.cpp:853
   // be predicated.  Until we have proper support for instruction clauses in the
-  // backend, we will mark KILL* instructions as unpredicable.

----------------
foad wrote:
> No, we're talking about predication so "unpredicable" is correct.
Ups, I didn’t predict that.

================
Comment at: llvm/lib/Target/AMDGPU/SIMachineScheduler.cpp:94
+// The OpenCL doc says for example latency of 400 cycles for a global mem
+// access, which is hidden by 10 instructions if the wavefront count is 10.

----------------
foad wrote:
> There is no typo fix here?
True, I guess clang-format just formatted the whole comment, not only the changed line. (The lines were longer than 80 chars)
Is it fine to leave these changes in the patch?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119235/new/

https://reviews.llvm.org/D119235