[PATCH] D119235: [AMDGPU][NFC] Fix typos

Carl Ritson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 10 00:56:55 PST 2022


critson added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp:980
   } else {
     // Kills deactivate lanes
     if (Op.isImm()) {
----------------
foad wrote:
> On second thoughts maybe "deactivated" was intended? And it needs to be fixed here too. @critson I think you wrote these comments.
I am not entirely sure what I meant by these comments, but protocol the first word is not meant to be a verb.
The two comments are probably meant to read:

// Demote - deactivate quads with only helper lanes

// Kill - deactivate lanes no longer in live mask


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119235/new/

https://reviews.llvm.org/D119235



More information about the llvm-commits mailing list