[PATCH] D115861: [LoongArch 4/6] Add basic tablegen infra for LoongArch

[Lu Weining via Phabricator via llvm-commits]

SixWeining added a comment.

In D115861#3304245 <https://reviews.llvm.org/D115861#3304245>, @xen0n wrote:

> Aside from my pet peeves against instruction format naming (and I agree to first merging as-is), only one minor comment and we're good to go!

Thanks for your agreement. I have replied the comment inline.



================
Comment at: llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchBaseInfo.h:36
+  OPERAND_SIMM16,
+  OPERAND_SIMM20,
+  OPERAND_LAST_LOONGARCH_IMM = OPERAND_SIMM20,
----------------
xen0n wrote:
> Sorry for noticing this late, but don't we have simm21 for BEQZ/BNEZ and simm26 for B/BL?
Thanks. This patch is just to add basic tablegen infra, so not all kinds of operand type are added here. Branch and function call would be implemented in future and related operand types would be added then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115861/new/

https://reviews.llvm.org/D115861